make buddies work better :-)
[spider.git] / perl / DXProtHandle.pm
index 166d56439f12c925cb50f7ffb92032fd460c39fb..c5f6cc81b2a7edcf0043b94e37ac2665d5dbceae 100644 (file)
@@ -1406,6 +1406,7 @@ sub _add_thingy
                } else {
                        dbg("ROUTE: added user $call to " . $parent->call) if isdbg('routelow');
                        @rout = $parent->add_user($call, Route::here($here));
+                       $dxchan->tell_buddies('loginb', $call, $parent->call) if $dxchan;
                }
                if ($pc92_slug_changes && $parent == $main::routeroot) {
                        $things_add{$call} = Route::get($call);
@@ -1419,6 +1420,7 @@ sub _del_thingy
 {
        my $parent = shift;
        my $s = shift;
+       my $dxchan = shift;
        my ($call, $is_node, $is_extnode, $here, $version, $build) = @$s;
        my @rout;
        if ($call) {
@@ -1428,9 +1430,12 @@ sub _del_thingy
                        dbg("ROUTE: deleting node $call from " . $parent->call) if isdbg('routelow');
                        @rout = $ref->del($parent) if $ref;
                } else {
-                       $ref = Route::User::get($call);
                        dbg("ROUTE: deleting user $call from " . $parent->call) if isdbg('routelow');
-                       @rout = $parent->del_user($ref) if $ref;
+                       $ref = Route::User::get($call);
+                       if ($ref) {
+                               $dxchan->tell_buddies('logoutb', $call, $parent->call) if $dxchan;
+                               @rout = $parent->del_user($ref);
+                       }
                }
                if ($pc92_slug_changes && $parent == $main::routeroot) {
                        $things_del{$call} = $ref unless exists $things_add{$call};
@@ -1755,12 +1760,13 @@ sub handle_92
                        push @radd, $add if $add;
                }
 
-               # do a pass through removing any references to either locally connected nodes or mycall
+               # do a pass through removing any references to either mycall
                my @nent;
                for (@ent) {
+                       my $dxc;
                        next unless $_ && @$_;
-                       if ($_->[0] eq $main::mycall || DXChannel::get($_->[0])) {
-                               dbg("PCPROT: $_->[0] refers to locally connected node, ignored") if isdbg('chanerr');
+                       if ($_->[0] eq $main::mycall) {
+                               dbg("PCPROT: $_->[0] refers to me, ignored") if isdbg('chanerr');
                                next;
                        }
                        push @nent, $_;
@@ -1772,7 +1778,7 @@ sub handle_92
                        }
                } elsif ($sort eq 'D') {
                        for (@nent) {
-                               push @rdel, _del_thingy($parent, $_);
+                               push @rdel, _del_thingy($parent, $_, $self);
                        }
                } elsif ($sort eq 'C') {
                        my (@nodes, @users);
@@ -1806,10 +1812,10 @@ sub handle_92
                        }
                        # del users here
                        foreach my $r (@$dnodes) {
-                               push @rdel,_del_thingy($parent, [$r, 1]);
+                               push @rdel,_del_thingy($parent, [$r, 1], $self);
                        }
                        foreach my $r (@$dusers) {
-                               push @rdel,_del_thingy($parent, [$r, 0]);
+                               push @rdel,_del_thingy($parent, [$r, 0], $self);
                        }
 
                        # remember this last PC92C for rebroadcast on demand
@@ -1836,6 +1842,42 @@ sub handle_92
        $self->broadcast_route_pc9x($pcall, undef, $line, 0);
 }
 
+# get all the routes for a thing, bearing in mind that the thing (e.g. a user)
+# might be on two or more nodes at the same time or that there may be more than
+# one equal distance neighbour to a node.
+#
+# What this means that if sh/route g1tlh shows that he is on (say) two nodes, then
+# a Route::findroutes is done on each of those two nodes, the best route(s) taken from
+# each and then combined to give a set of dxchans to send the PC9x record down
+#
+sub find_pc9x_routes
+{
+       my $to = shift;
+       my $ref = Route::get($to);
+       my @parent;
+       my %cand;
+
+       if ($ref->isa('Route::User')) {
+               my $dxchan = DXChannel::get($to);
+               push @parent, $to if $dxchan;
+               push @parent, @{$ref->parent};
+       } else {
+               @parent = $to;
+       }
+       foreach my $p (@parent) {
+               my $lasthops;
+               my @routes = Route::findroutes($p);
+               foreach my $r (@routes) {
+                       $lasthops = $r->[0] unless defined $lasthops;
+                       if ($r->[0] == $lasthops) {
+                               $cand{$r->[1]->call} = $r->[1];
+                       } else {
+                               last;
+                       }
+               }
+       }
+       return values %cand;
+}
 
 sub handle_93
 {
@@ -1896,45 +1938,26 @@ sub handle_93
        # if it is routeable then then treat it like a talk
        my $ref = Route::get($to);
        if ($ref) {
-               # local talks
                my $dxchan;
-               $dxchan = DXChannel::get($main::myalias) if $to eq $main::mycall;
-               $dxchan = DXChannel::get($to) unless $dxchan;
-               # check it...
-               if ($dxchan) {
-                       if (ref $dxchan && $dxchan->isa('DXChannel')) {
-                               if ($dxchan->is_user) {
-                                       $dxchan->talk($from, $to, $via, $text, $onode);
-                                       return;
-                               }
-                       } else {
-                               dbg("ERROR: $to -> $dxchan is not a DXChannel! (local talk)");
-                       }
-               }
 
-               # convert to PC10 talks where appropriate
+               # convert to PC10 or local talks where appropriate
                # PC93 capable nodes of the same hop count all get a copy
                # if there is a PC10 node then it will get a copy and that
                # will be it. Hopefully such a node will not figure highly
                # in the route list, unless it is local, 'cos it don't issue PC92s!
-               my @routes = Route::findroutes($to);
+               # note that both local and PC93s at the same time are possible if the
+               # user on more than one node.
+               my @routes = find_pc9x_routes($to);
                my $lasthops;
-               foreach my $r (@routes) {
-                       $lasthops = $r->[0] unless defined $lasthops;
-                       if ($r->[0] == $lasthops) {
-                               $dxchan = $r->[1];
-                               if (ref $dxchan && $dxchan->isa('DXChannel')) {
-                                       if ($dxchan->{do_pc9x}) {
-                                               $dxchan->send($line);
-                                       } else {
-                                               $dxchan->talk($from, $to, $via, $text, $onode);
-                                               last;
-                                       }
+               foreach $dxchan (@routes) {
+                       if (ref $dxchan && $dxchan->isa('DXChannel')) {
+                               if ($dxchan->{do_pc9x}) {
+                                       $dxchan->send($line);
                                } else {
-                                       dbg("ERROR: $to -> $dxchan is not a DXChannel! (convert to pc10)");
+                                       $dxchan->talk($from, $to, $via, $text, $onode);
                                }
                        } else {
-                               last;
+                               dbg("ERROR: $to -> $dxchan is not a DXChannel! (convert to pc10)");
                        }
                }
                return;